Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typings #287

Merged
merged 3 commits into from
Jun 4, 2019
Merged

Update typings #287

merged 3 commits into from
Jun 4, 2019

Conversation

glen-cheney
Copy link
Owner

@glen-cheney glen-cheney commented Jun 3, 2019

Fixes

  • Fix bad default parameters for enable, update, and getSize.
  • Fix missing Css export on Shuffle.ShuffleItem.Css.
  • Fix Shuffle.ALL_ITEMS and Shuffle.FILTER_ATTRIBUTE_KEY not being overridable.

New

  • Add types for .sort() method's options: SortOptions.
  • Add types for .filter()'s function signature.
  • Add types for ShuffleItem.Css.

Tests

  • Add test ts file.
  • Run tsc on test file during tests.

Breaking (TypeScript only)

  • Changed all Element to HTMLElement.
  • Shuffle.ShuffleOptions is now exported top-level.
    import Shuffle, { ShuffleOptions, SortOptions } from 'shufflejs';

@glen-cheney glen-cheney merged commit dc219da into master Jun 4, 2019
@glen-cheney glen-cheney deleted the update-type-defs branch June 4, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant